| # | Time | Nick | Message |
|---|
| # | 00:22:39 | atz has quit IRC |
| # | 01:58:59 | miker_ has quit IRC |
| # | 02:02:29 | miker_ has joined #evergreen |
| # | 04:38:15 | lisppaste has quit IRC |
| # | 07:47:42 | sfortin has joined #evergreen |
| # | 07:57:44 | kmlussier has joined #evergreen |
| # | 08:15:43 | Dyrcona has joined #evergreen |
| # | 08:35:58 | shopkins has joined #evergreen |
| # | 08:39:53 | gdunbar has joined #evergreen |
| # | 08:59:45 | dbs has joined #evergreen |
| # | 09:01:04 | mck9 has left #evergreen |
| # | 09:01:23 | mck9 has joined #evergreen |
| # | 09:05:51 | kmlussier has quit IRC |
| # | 09:15:34 | brendan_bywater has joined #evergreen |
| # | 09:18:39 | tsbere has joined #evergreen |
| # | 09:20:45 | dbs has quit IRC |
| # | 09:24:10 | StephenGWills has joined #evergreen |
| # | 09:27:52 | bshum has joined #evergreen |
| # | 09:36:43 | jenny has joined #evergreen |
| # | 09:37:54 | yboston has joined #evergreen |
| # | 09:46:01 | r123 has joined #evergreen |
| # | 09:48:12 | Meliss has joined #evergreen |
| # | 09:50:09 | dbs has joined #evergreen |
| # | 09:54:39 | atz has joined #evergreen |
| # | 09:58:28 | jeff | i like that patrons can always fall back to their barcode if they forget their username. |
| # | 09:59:04 | tsbere | What do you do if they can't remember their barcode? ;) |
| # | 09:59:08 | jeff | i don't like some of the resulting quirks of the current implementation, though. something to go on my long list. |
| # | 09:59:51 | jeff | current quirk in front of me: staff changed username to something that was all-numeric and didn't correspond with any of the patron's barcodes, therefore patron couldn't log in with the username staff sent them home with. |
| # | 10:00:10 | jeff | tsbere: and in this case, patron didn't have their library card number handy. :) |
| # | 10:00:40 | tsbere | wait, an all-numeric username will break the ability to log in with that username unless it corresponds to a barcode on the account? |
| # | 10:03:00 | granitize has joined #evergreen |
| # | 10:05:41 | jeff | tsbere: in the opac login, there's a regex (an ou setting, iirc) for "is this a barcode or a username?" -- since mis-identifying a username as a barcode will prevent login, My Account attempts to prevent patrons from setting a username that looks like a barcode. |
| # | 10:05:50 | jeff | there is no such restriction in place for staff. :) |
| # | 10:06:07 | alxp has joined #evergreen |
| # | 10:16:07 | atz | that's the inconvenince you create from trying to make things too convenient |
| # | 10:26:32 | jeff | my thought is to make the regex a "first guess", and if auth fails fall back to the other. |
| # | 10:26:56 | tsbere | how does the staff interface do it? |
| # | 10:27:23 | tsbere | My thought would be "always assume it is a barcode. If it isn't, then assume it is a username" |
| # | 10:27:30 | jeff | that still leaves a tiny corner case where two users with the same password could end up signing in as the same user if one had a username that matched the other's barcode. |
| # | 10:27:59 | jeff | the other potential would be to maintain (via trigger, likely) a central table of all barcodes and usernames, and not permit conflicts. |
| # | 10:28:18 | jeff | that could be overkill, though it could also simplify auth |
| # | 10:29:15 | tsbere | When setting a username just do a query of "is this in use as a barcode" and when setting a barcode just do a query of "is this in use as a username"? |
| # | 10:29:30 | tsbere | I assume (am not checking) that dupe username will fail and dupe barcode will fail anyway in their own areas |
| # | 10:30:11 | jeff | currently you can't have the same barcode as another barcode in the system, and you can't have the same username. no problems there. |
| # | 10:30:31 | jeff | but (in some not-too-corner cases) you can have a username that is someone else's barcode. |
| # | 10:30:44 | tsbere | So the code, when setting either, just needs to check that the value isn't in the other set |
| # | 10:32:44 | jeff | if you're going to go that far, and declare that they must be unique, i think it's better to have that uniqueness enforced at a lower level, in the db itself. |
| # | 10:32:52 | jeff | (you might have been saying that) |
| # | 10:32:53 | miker_ | a CHECK constraint can handle that |
| # | 10:33:04 | miker_ waits for a patch ;) |
| # | 10:33:10 | jeff grins |
| # | 10:33:47 | jeff | miker_: the hardest part would be the upgrade script, and what to do if your data doesn't pass the new constraint. ;-) |
| # | 10:34:03 | miker_ | indeed |
| # | 10:38:40 | shadowspar has quit IRC |
| # | 10:49:04 | r123 has quit IRC |
| # | 10:53:01 | youdonotexist has joined #evergreen |
| # | 10:53:40 | jamesrf has joined #evergreen |
| # | 10:58:38 | r123 has joined #evergreen |
| # | 11:05:49 | dbs | hmm - how would a CHECK constraint handle that? I thought they could only access other columns in the same row as the one being checked - not other rows |
| # | 11:10:59 | jeff | i don't know. miker_? |
| # | 11:30:50 | shadowspar has joined #evergreen |
| # | 11:36:42 | atz | i don't get the point of allowing two fields then. really you're talking about uniqueness in one field, with some other designation of barcode/username |
| # | 11:41:00 | jeff | talking about allowing any of the values of actor.usr.usrname or actor.card.barcode (where card.usr = usr.id and card.active true) |
| # | 11:41:06 | dbs | Maybe it's more of a UI problem than a database schema problem. Make it clear that you're logging in with a username, with a nice easy option to switch to barcode, and maybe that solves the problem? |
| # | 11:41:34 | jeff | i'd rather have a single field for login. |
| # | 11:41:50 | dbs | Have the options switchable by radio button, an image of a library card beside the barcode option? |
| # | 11:42:04 | jeff | i don't see the added option benefiting the user at all, just the programmers/staff. |
| # | 11:42:07 | dbs | Or just not allow usernames then |
| # | 11:42:10 | jeff | heh |
| # | 11:42:28 | afterl has joined #evergreen |
| # | 11:43:02 | jeff | i think "regex tells us which to try first, try both" will meet our needs. |
| # | 11:43:25 | dbs | But what if they enter their phone number or SSN? Those poor dumb users. |
| # | 11:43:26 | jeff | it's just a minor change from the current implementation, where the regex dictates which method (username or barcode) is used, with no fallback. |
| # | 11:43:39 | jeff | if they enter their phone number or ssn, that's up to them. |
| # | 11:43:57 | jeff | neither phone number nor ssn look like a barcode, so we'll still guess correctly the first time :) |
| # | 11:44:22 | dbs | Depends on how dumb your regex is :) |
| # | 11:44:24 | jeff | oh, and if they're trying to log in with their phone number? no. that won't work. i do not need that to work. :) |
| # | 11:45:14 | tsbere | what if they want to log in with their DB ID? :P |
| # | 11:45:37 | dbs | tsbere++ |
| # | 12:01:40 | jeff | that just won't do, but we will need to make sure that they can log in with their holds alias. |
| # | 12:02:17 | tsbere doesn't like finding comments like "huh?" on code. Especially when his reaction WAS to go "huh?" and was hoping the comment would be helpful when he moved the window so he could read it. |
| # | 12:02:31 | jeff | (YES I'M KIDDING) |
| # | 12:02:39 | jeff | tsbere: nice. :) |
| # | 12:02:53 | jeff | tsbere: at least it's confirmation that you're not the only one looking at it and scratching your head. |
| # | 12:03:12 | tsbere | The line of code? location.href = location.href; // huh? |
| # | 12:03:25 | atz | er.... say what? |
| # | 12:04:42 | tsbere | line 447 of main.js in the staff client, I believe? |
| # | 12:05:35 | jeff | i believe that's a quick shortcut for "clear state on this page to the default" |
| # | 12:05:36 | dbs | Time to follow the revision log for that file back through history to find out how that line evolved |
| # | 12:05:50 | jeff | it's also used in Open-ILS/web/templates/default/acq/picklist/from_bib.tt2 in a button labeled "Begin a new search" |
| # | 12:06:12 | atz | is that a poor man's "refresh" ? |
| # | 12:06:43 | tsbere | I think it may be intended as a "refresh without any pesky POST elements". Not sure. |
| # | 12:06:59 | atz | right... i think that would be the result |
| # | 12:07:19 | tsbere | The comment doesn't help much in figuring that out, though. :P |
| # | 12:15:37 | atz | i leave comments like that sometimes... usually on somebody else's code, but occasionally on my own like "what was I thinking here?" |
| # | 12:20:15 | r123 has quit IRC |
| # | 12:22:58 | dbs | well, now we know who added that comment: http://svn.open-ils.org/trac/ILS/changeset/8624/trunk/Open-ILS/xul/staff_client/chrome/content/main/main.js |
| # | 12:23:57 | tsbere | Who added the line, though? :P |
| # | 12:24:51 | miker_ | sorry ... away from my desk |
| # | 12:24:51 | dbs | History of main.js doesn't go back that far |
| # | 12:25:06 | dbs | stops at http://svn.open-ils.org/trac/ILS/changeset/2848/trunk/Open-ILS/xul/staff_client/chrome/content/main/main.js |
| # | 12:25:22 | tsbere | ok |
| # | 12:25:25 | miker_ | a CHECK could run a function against actor.card.barcode and make sure that there's no match in actor.usr.usrname, and vice versa |
| # | 12:26:54 | dbs | Huh. I read "Currently, CHECK expressions cannot contain subqueries nor refer to variables other than columns of the current row." as being more limiting than that, but if you can run functions then anything is on the table |
| # | 12:27:53 | miker_ | dbs: that's at the top level, a function can do anything it likes, but it can only take colums from the current row as params |
| # | 12:29:14 | miker_ | anything (except subqueries) that can appear in a WHERE clause and only use the columns from the current table (and litterals) should work fine |
| # | 12:30:27 | dbs | sweet. the world is our (constrained) oyster! |
| # | 12:33:38 | dbs briefly considers adding a clarification + example to that page, but there's only so many projects to burn his energy on |
| # | 12:39:01 | lisppaste has joined #evergreen |
| # | 12:39:16 | bshum | Is there any way to hide information from the rdetails page when they're blank? For example, we seem to have some records with no edition information, but the field still shows up with a blank next to it. |
| # | 12:40:37 | bshum | Same with the abstract. |
| # | 12:43:22 | dbs | bshum: there are examples in the Conifer lul skin |
| # | 12:43:26 | r123 has joined #evergreen |
| # | 12:43:48 | bshum | dbs: Awesome! We'll go take a peek then. |
| # | 12:44:04 | dbs | See the very top of http://svn.open-ils.org/trac/ILS-Contrib/browser/conifer/branches/rel_1_6_0/web/opac/skin/lul/xml/rdetail/rdetail_summary.xml |
| # | 12:45:00 | dbs | you still need an ID for rdetail.js to slip its mods_slim version of the metadata, but it can be hidden so that no-one ever sees it |
| # | 12:45:35 | dbs | and then you can see that the trick for all of the BibTemplate-provided entries is that they are hidden by default, then unhidden if there is some content to display |
| # | 12:46:49 | atz | hrm... 0357 fails for me |
| # | 12:46:51 | atz | ERROR: creation of Perl function "translate_isbn1013" failed: Can't locate Business/ISBN.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at line 2. |
| # | 12:47:03 | atz | guess i know how to fix that... |
| # | 12:47:21 | granitize | We're using the same hideme bibTemplate stuff some additional configs to do yet. |
| # | 12:49:03 | granitize | How can I make this link http://islandpines.roblib.upei.ca/opac/extras/feed/bookbag/opac/466 redirect to my custom skin instead of default? |
| # | 12:50:03 | granitize | hmm and why is the search results empty! :-( |
| # | 12:51:51 | miker_ | granitize: right now, you can use a URL rewrite to point all access (or just access that uses a record list) to the default skin at your custom one |
| # | 12:52:57 | granitize | miker: Will a global rewrite effect the staff client? |
| # | 12:53:30 | bshum | dbs: Yay! Thanks for showing us a copy of that page, it's very enlightening. We'll tinker with our page and see what happens. |
| # | 12:53:54 | dbs | atz: heh |
| # | 12:53:56 | bshum | dbs: Is it possible to have a bunch of different tags show up in the same block or can they only exist as separate entries? |
| # | 12:54:29 | dbs | granitize: I'm pretty sure I added a skin CGI param |
| # | 12:54:53 | granitize | bshum: I use divs inside the td to list all subjects (700's?) |
| # | 12:55:00 | granitize | dbs: Thanks... I'll look. |
| # | 12:56:56 | dbs | granitize: witness http://laurentian.concat.ca/opac/extras/feed/bookbag/opac/1911?skin=lul&searchOrg=OSUL |
| # | 12:57:18 | granitize | bshum: umm sorry... we use originator and 100 and 700's |
| # | 12:57:27 | dbs | vs. http://laurentian.concat.ca/opac/extras/feed/bookbag/opac/1911?skin=uwin&searchOrg=OSUL |
| # | 12:57:49 | granitize | bshum: http://islandpines.roblib.upei.ca/opac/en-CA/skin/roblib/xml/rdetail.xml?r=792247&ol=4&t=medicine&tp=keyword&l=4&d=2&hc=5303&rt=keyword |
| # | 12:58:26 | granitize | skin= |
| # | 13:00:08 | granitize | lovely |
| # | 13:01:07 | miker_ | dbs: nice ... available elsewhere? |
| # | 13:01:26 | dbs | miker_: hell yeah, I committed that to 1.6 like a year ago :) |
| # | 13:01:42 | miker_ | dbs++ |
| # | 13:05:52 | bshum | granitize: Neat, thanks for sharing. Off to tinker more. |
| # | 13:15:33 | dbs | Huh, oddly enough it was just over a year ago that skin & locale params were added: http://svn.open-ils.org/trac/ILS/changeset/13533/branches/rel_1_6_0/Open-ILS/src/perlmods/OpenILS/WWW/SuperCat.pm |
| # | 13:15:41 | dbs | Sometimes I don't lie! |
| # | 13:17:51 | granitize | skin= locale=... dbs +++ |
| # | 13:21:34 | kmlussier has joined #evergreen |
| # | 13:29:00 | jenny has quit IRC |
| # | 13:30:13 | kmlussier has quit IRC |
| # | 13:31:58 | granitize | Could I just change the code in supercat.pm to use en-CA and custom skin so people building links don't have to add the parameters? |
| # | 13:33:26 | dbs | You certainly could |
| # | 13:33:46 | dbs | Just watch out when you upgrade to a new version of Evergreen that you remember to apply that customization |
| # | 13:33:49 | granitize | dbs: What else would be effected? |
| # | 13:33:55 | granitize | right. |
| # | 13:34:00 | granitize | affected? |
| # | 13:35:02 | dbs | nothing i can think of |
| # | 13:35:37 | dbs | Wouldn't help a multi-library consortium with multiple skins, but should be fine for roblib |
| # | 13:36:17 | granitize | Cool - Until we add a new branch for Journals or something. |
| # | 13:41:18 | granitize | or I can set the variable! $skin = $cgi->param('skin') || 'default'; |
| # | 13:41:18 | granitize | my $locale = $cgi->param('locale') || 'en-US'; |
| # | 13:41:39 | pmplett has joined #evergreen |
| # | 13:44:35 | jamesrf has quit IRC |
| # | 13:47:04 | dbs | right, change the defaults from 'default' and 'en-US' to what you want - sorry, I thought that was where you were headed :) |
| # | 13:51:04 | yboston has quit IRC |
| # | 13:52:29 | jamesrf has joined #evergreen |
| # | 13:54:24 | jenny has joined #evergreen |
| # | 13:56:39 | yboston has joined #evergreen |
| # | 13:58:55 | rickd_ has quit IRC |
| # | 13:59:42 | tsbere has quit IRC |
| # | 14:20:16 | leed | for eg 1611 should we use osrf 1.2.2 or 1.4.0? |
| # | 14:21:11 | dbs | 1.2.2 is fine, but 1.4.0 _should_ work |
| # | 14:21:42 | leed | ill go with fine over should :-) |
| # | 14:22:19 | dbs | bah. need to encourage 1.4.0 adoption. |
| # | 14:22:45 | rickd_ has joined #evergreen |
| # | 14:25:07 | granitize | after a supercat.pm mod what restarts...just perl? |
| # | 14:27:40 | dbs | apache |
| # | 14:27:53 | dbs | Just apache, for OpenILS::WWW:SuperCat.pm |
| # | 14:28:16 | granitize | dbs: thanks |
| # | 14:30:07 | bshum | granitize: Hmm, been tinkering with our code but still can't make it work like yours with the example you gave for the originators and 100/700 tags. Could you possibly share that portion of your rdetail_summary.xml file with us? |
| # | 14:32:30 | csharp | is there a "recommended specs" anywhere on the open-ils.org site for running the staff client? |
| # | 14:32:51 | dbs | Minimum of Windows 95, > 256 MB RAM? :) |
| # | 14:32:55 | csharp | heh |
| # | 14:32:57 | granitize | bshum: yup... give me a sec. |
| # | 14:33:21 | dbs | bshum: are you just looking to pull multiple tags at once via dojo.query? |
| # | 14:33:45 | bshum | dbs: I believe that's what we're aiming for. Or multiple subfields. |
| # | 14:33:47 | granitize | damn - I have a smokin' windows 3.11 with 128MB |
| # | 14:34:46 | bshum | csharp: The closest thing I found was this old page: http://evergreen-ils.org/dokuwiki/doku.php?id=system_requirements |
| # | 14:35:05 | bshum | There's a tiny line in there about staff client, but not really any details. |
| # | 14:35:14 | bshum | *specifics, rather |
| # | 14:36:40 | csharp | bshum: thanks! |
| # | 14:38:11 | bshum | The page author was phasefx, so maybe he's our best bet to egg out a more defined answer ;) |
| # | 14:40:19 | lisppaste | granitize pasted "Originator 700and 100 using span tags" at http://paste.lisp.org/display/113128 |
| # | 14:41:57 | granitize | stolen and hacked till it worked! |
| # | 14:42:07 | bshum | granitize: Ahh, we had the span order wrong and that's what was causing our hiccups. |
| # | 14:42:13 | bshum | granitize: Thanks so much for sharing this! |
| # | 14:43:33 | granitize | bshum: Wish I could share more... I depend on others expertise a lot! |
| # | 14:45:28 | granitize | dbs: restart apache has no effect |
| # | 14:46:33 | kmlussier has joined #evergreen |
| # | 14:49:42 | dbs | granitize: can you paste your supercat.pm? |
| # | 14:50:59 | jenny has quit IRC |
| # | 14:52:17 | jenny has joined #evergreen |
| # | 14:56:50 | dbs | granitize: just trying to ensure that you made the changes in the right spots |
| # | 15:03:52 | granitize | openils/lib/perl5/OpenILS/WWW/SuperCat.pm |
| # | 15:05:07 | dbs | heh, I can't read that :) |
| # | 15:05:16 | granitize | heh |
| # | 15:05:30 | granitize | just a location check. |
| # | 15:05:53 | lisppaste | granitize pasted "untitled" at http://paste.lisp.org/display/113132 |
| # | 15:06:09 | granitize | Just changed these two lines |
| # | 15:07:49 | dbs | granitize: in all four locations where those lines occur? |
| # | 15:08:27 | dbs | specifically in the bookbag_feed sub |
| # | 15:10:05 | granitize | noooooo ... variable need to be declared once... right! RTFC |
| # | 15:10:56 | granitize | sigh... |
| # | 15:11:45 | granitize | thanks |
| # | 15:11:57 | dbs | np! |
| # | 15:13:57 | granitize | what about <Language>en-US</Language> and |
| # | 15:13:59 | granitize | $terms = decode_utf8($terms); |
| # | 15:13:59 | granitize | $lang = 'eng' if ($lang eq 'en-US'); |
| # | 15:22:00 | dbs | Are you doing anything significant with opensearch? |
| # | 15:22:43 | granitize | probably not, as I'm unsure what it is... |
| # | 15:25:31 | granitize | We were but we liked the bookbag to skin look better. |
| # | 15:27:29 | granitize | might be a few links left scattered. |
| # | 15:30:14 | granitize | and I use in in Libx as a "Lightweight" catalogue |
| # | 15:32:12 | dbs | Yeah. i don't know that I would touch those bits, personally. (I certainly wouldn't touch the decode_utf8() call) |
| # | 15:52:17 | jenny has quit IRC |
| # | 16:00:32 | shopkins | leaving |
| # | 16:00:36 | shopkins has quit IRC |
| # | 16:02:16 | Meliss has quit IRC |
| # | 16:09:51 | sfortin has quit IRC |
| # | 16:18:06 | granitize has quit IRC |
| # | 16:22:25 | brendan_bywater has quit IRC |
| # | 16:24:08 | bshum has quit IRC |
| # | 16:31:45 | moodaepo | When does the email hold notification to a patron go out, when captured I think? What's the difference between capture time and fulfillment time? |
| # | 16:32:19 | kmlussier has quit IRC |
| # | 16:33:04 | berick | moodaepo: notice is generated when the captured copy reaches the pickup location. fulfillment time is when the captured copy is checked out to the user. |
| # | 16:33:45 | moodaepo | berick++ # That's what we thought but were not sure. |
| # | 16:35:14 | alxp has quit IRC |
| # | 16:42:20 | mck9 | Dibs on # 0359 for an upgrade script |
| # | 16:42:22 | brendan_bywater has joined #evergreen |
| # | 16:49:07 | jenny has joined #evergreen |
| # | 16:49:22 | jenny has left #evergreen |
| # | 17:02:45 | afterl has quit IRC |
| # | 17:05:37 | dbs has quit IRC |
| # | 17:24:34 | yboston has quit IRC |
| # | 17:28:54 | jamesrf has quit IRC |
| # | 17:29:18 | Dyrcona has quit IRC |
| # | 17:29:24 | pmplett has quit IRC |
| # | 18:22:41 | StephenGWills has quit IRC |
| # | 18:27:28 | youdonotexist has quit IRC |
| # | 18:34:09 | jamesrf has joined #evergreen |
| # | 19:28:54 | pmplett has joined #evergreen |
| # | 20:54:19 | jamesrf has quit IRC |
| # | 21:39:35 | dbs has joined #evergreen |
| # | 21:58:17 | pmplett has quit IRC |
| # | 22:39:36 | pmplett has joined #evergreen |
| # | 22:46:19 | pmplett has quit IRC |
| # | 22:48:32 | pmplett has joined #evergreen |
| # | 23:12:43 | cerpy has joined #evergreen |
| # | 23:25:20 | dbs waves at cerpy |
| # | 23:37:40 | cerpy has quit IRC |
| # | 23:38:47 | cerpy has joined #evergreen |
| # | 23:48:04 | mck9 has left #evergreen |
| # | 23:58:36 | dbs | atz: should the Cstore*.t files in Open-ILS/src/support-scripts move to some place like Open-ILS/tests/something ? |
| # | 23:59:15 | atz | if we actually did something w/ tests, yeah |
April 10-13