| # | Time | Nick | Message |
|---|
| # | 00:19:38 | dbs has quit IRC |
| # | 06:21:25 | sarabee has quit IRC |
| # | 06:38:32 | sarabee_ has joined #openils-evergreen |
| # | 08:23:11 | sarabee_ has quit IRC |
| # | 09:26:09 | dbs has joined #openils-evergreen |
| # | 09:27:07 | sarabee has joined #openils-evergreen |
| # | 12:53:59 | phasefx | dbs++ upei++ |
| # | 13:03:18 | miker_ | dbs++ indeed |
| # | 13:04:02 | miker_ | dbs: I'm looking at #43 ... is it possible that University Library (4th level) has can_have_vols=f? |
| # | 13:04:26 | dbs | miker_: nope - check SL1 in the default EG install, same problem |
| # | 13:04:45 | miker_ | k |
| # | 13:05:01 | dbs | (course, now I've gotta go check) |
| # | 13:06:24 | dbs | miker_: yep, just checked; University (3rd level) and University Library (4th level) both have can_have_vols=t |
| # | 13:06:45 | miker_ | k |
| # | 13:08:50 | dbs | phasefx, miker_: thanks for the karma. sorry for the roughshod approach. |
| # | 13:09:14 | miker_ | nono ... all's well. as you said, that's what trunk is for |
| # | 13:10:35 | dbs | http://tvt.blogspot.com/2009/03/evergreen-patch-accepted.html |
| # | 13:11:59 | miker_ | nice :) |
| # | 13:17:31 | miker_ | translating SQL to json for fun and profit: http://rafb.net/p/XN1klc94.html ;) |
| # | 13:17:37 | miker_ waits for screams |
| # | 13:18:20 | dbs | well, I guess it's really what a feature branch is for :) |
| # | 13:19:01 | dbs | miker_: heh. it's like sql, except harder to read (for me) :) |
| # | 13:19:32 | phase_bb2 has joined #openils-evergreen |
| # | 13:21:02 | dbs | "give me the distinct set of circ event triggers for this user where state is pending or in error"? |
| # | 13:22:26 | miker_ | dbs: ineed |
| # | 13:22:32 | miker_ | on bot counts |
| # | 13:22:35 | miker_ | noth |
| # | 13:22:37 | miker_ | both |
| # | 13:22:43 | miker_ takes a typing class |
| # | 13:22:45 | dbs | @count |
| # | 13:22:45 | pinesol | dbs: Error: "count" is not a valid command. |
| # | 13:26:08 | phase_bb has quit IRC |
| # | 13:38:16 | miker_ | dbs: gonna talk my way through 43 ... ignore as appropriate ;) |
| # | 13:38:23 | dbs | absolutely |
| # | 13:38:37 | dbs | I just can't figure out why the expected recursion doesn't occur |
| # | 13:39:37 | miker_ | so, we're in showLocal mode .. and not at the top of the tree, and ... do we have a node? hrm... no, because we're at the system level (first call) |
| # | 13:40:47 | miker_ | wait ... not at system, at library |
| # | 13:40:53 | miker_ | but still no node |
| # | 13:41:38 | miker_ | so, we loop over the first level kids in the tree, looking for the depth=1 anscestor of the current location |
| # | 13:42:04 | miker_ | we find the anscestor Local Library System |
| # | 13:43:46 | miker_ | we discover after building the result row that this does not have can_have_vols, so we remove the data sections and append the row |
| # | 13:44:19 | miker_ | then we loop over the children of that, and we /do/ pass the org (node) to the recursive call |
| # | 13:45:02 | miker_ | now we're at the University System level, with a node, and still in showLocal |
| # | 13:45:25 | miker_ | well ... there we go |
| # | 13:45:55 | miker_ | we have a node, and we're inside the first if() block. so we test thusly: |
| # | 13:45:59 | miker_ | if( !orgIsMine(loc, node) ) return; |
| # | 13:46:24 | miker_ | which says "if node is not a descendent of loc, bail" |
| # | 13:46:58 | miker_ | which is exactly correct, per the test, because node is a University System node, and loc is a University Library node |
| # | 13:47:19 | dbs | makes sense |
| # | 13:47:33 | dbs | when you keep all the vars straight like that |
| # | 13:47:34 | miker_ | it works with 3 levels, because orgIsMine(x,x) returns true (same org is a "my org") |
| # | 13:48:31 | miker_ | so, I think we just need to swap loc and node in if( !orgIsMine(loc, node) ) return; ... mind testing with: if( !orgIsMine(node,loc) ) return; ? |
| # | 13:48:46 | dbs | will give it a shot, one sec |
| # | 13:49:06 | dbs | at some point I have to prepare for tomorrow morning's deadly early flight |
| # | 13:49:17 | miker_ | :) |
| # | 13:53:47 | miker_ | how deadly early? |
| # | 13:53:58 | miker_ | "deadly enough, jackass" |
| # | 13:54:48 | dbs tries to force firefox to grab the updated copy of rdetail.js from the server; fails |
| # | 13:54:56 | miker_ | gah |
| # | 13:55:04 | miker_ | dbs: url? |
| # | 13:55:14 | dbs | s'ok, just restarting firefox |
| # | 13:55:45 | dbs | i suspect firebug plays a part in defeating Shift-Reload |
| # | 13:56:13 | miker_ | ahh... yeah, I turn that off when I don't actively NEEEEED it. |
| # | 13:58:19 | dbs | bahhhh! http://dwarf.cs.uoguelph.ca/opac/en-US/skin/default/js/rdetail.js |
| # | 13:58:32 | dbs | I have changed the file on the server, restarted apache, ARGH |
| # | 14:00:08 | dbs restarts apache again, as opera picks up the same file |
| # | 14:00:49 | dbs | ugh, dbs unsafe at any speed - wrong skin |
| # | 14:01:39 | dbs | that fixed it, indeed |
| # | 14:02:24 | dbs | works in opera, too |
| # | 14:02:25 | miker_ | yay! ... I'll commit, then, and close the ticket ... it works at the university system level, yes? |
| # | 14:02:28 | dbs | miker_++ |
| # | 14:03:13 | dbs | aye |
| # | 14:04:17 | dbs | between fixing that bug, and adding google integration, our folks will be heartened. now we just need to bang out an acquisition system ;) |
| # | 14:04:45 | dbs | oh, and the answer to your question: 4:30 am pickup for a 6:15 am flight |
| # | 14:10:33 | natschil has joined #openils-evergreen |
| # | 14:11:58 | dbs | miker_: argh... would it be possible for that to not work in Internet Explorer? |
| # | 14:12:16 | dbs goes to check to see what version of rdetails.js IE is pulling down |
| # | 14:13:10 | miker_ | dbs: I can't see how the param order would matter :( |
| # | 14:13:16 | miker_ | hrm... |
| # | 14:13:30 | miker_ | let's commit this, then look at IE |
| # | 14:14:18 | dbs | Yeah. Might be lingering interference with the still-failing openils.I18N |
| # | 14:14:27 | dbs | http://dwarf.cs.uoguelph.ca/opac/en-US/skin/default/xml/rdetail.xml?l=103&d=3&t=mining&tp=keyword&hc=9980&r=126095&rt=keyword |
| # | 14:15:00 | dbs | bet that's what the problem is |
| # | 14:17:03 | dbs | hmm, works in trunk. okay, never mind. got some backporting to do, methinks |
| # | 14:17:26 | miker_ | k |
| # | 14:17:36 | miker_ | I'll backport this to 1.4 and 1.4.0 |
| # | 14:17:48 | miker_ | this being the param swap |
| # | 14:18:06 | dbs | (openils.I18N is still failing, but we've switched the order in trunk so that it doesn't kill dijit.filteringSelect which throws an exception and brings everything to a crashing halt) |
| # | 14:18:17 | dbs | right-o - fabulous |
| # | 14:18:31 | dbs | and close :) |
| # | 14:24:27 | dbs | hmm, it might not work in IE in trunk :( |
| # | 14:25:41 | miker_ | I suspect 'for ( x in [] )' vs 'for (x; x < [].length; x++)' in IE ... want to try another patch in a sec? |
| # | 14:26:06 | dbs | ie-- |
| # | 14:26:17 | dbs | sure |
| # | 14:27:12 | miker_ | http://rafb.net/p/h9k4ky14.html |
| # | 14:27:38 | miker_ | if that makes it happy I'll fix the dojo-fied version too |
| # | 14:30:26 | dbs | i think that broke it |
| # | 14:30:55 | miker_ | huh |
| # | 14:31:55 | miker_ | in ffx? |
| # | 14:32:56 | miker_ | yeah ... me.children() is undefined |
| # | 14:34:13 | dbs gots to shower and pack and such |
| # | 14:34:23 | miker_ | is this in the default skin on dwarf? |
| # | 14:34:24 | dbs | thanks a ton, miker_, we're making headway on ancient bugs |
| # | 14:34:30 | dbs | yep |
| # | 14:34:33 | miker_ | ok ... have a good flight! |
| # | 14:34:36 | dbs | I just pulled it back out |
| # | 14:34:39 | miker_ | k |
| # | 14:35:01 | dbs | thanks! |
| # | 15:04:21 | natschil has quit IRC |
| # | 15:04:45 | natschil has joined #openils-evergreen |
| # | 15:09:51 | natschil has quit IRC |
| # | 15:09:56 | _natschil has joined #openils-evergreen |
| # | 15:14:08 | rsinger has quit IRC |
| # | 15:14:08 | berick has quit IRC |
| # | 15:14:08 | miker_ has quit IRC |
| # | 15:15:05 | rsinger has joined #openils-evergreen |
| # | 15:15:05 | berick has joined #openils-evergreen |
| # | 15:15:05 | miker_ has joined #openils-evergreen |
| # | 15:44:00 | lisppaste6 has quit IRC |
| # | 15:53:33 | djfiander has joined #OpenILS-Evergreen |
| # | 15:58:06 | _natschil has quit IRC |
| # | 16:25:19 | lisppaste6 has joined #openils-evergreen |
| # | 17:28:48 | djfiander has quit IRC |
| # | 21:39:19 | dbs has quit IRC |
| # | 21:41:04 | dbs has joined #openils-evergreen |
| # | 22:16:06 | dbs has quit IRC |