Open Source Integrated Library System

Evergreen on IRC

#openils-evergreen Logs for Sunday, March 8th, 2009

< Saturday, March 7th, 2009Raw Log FileMonday, March 9th, 2009 >
#TimeNickMessage
#00:19:38dbs has quit IRC
#06:21:25sarabee has quit IRC
#06:38:32sarabee_ has joined #openils-evergreen
#08:23:11sarabee_ has quit IRC
#09:26:09dbs has joined #openils-evergreen
#09:27:07sarabee has joined #openils-evergreen
#12:53:59phasefxdbs++ upei++
#13:03:18miker_dbs++ indeed
#13:04:02miker_dbs: I'm looking at #43 ... is it possible that University Library (4th level) has can_have_vols=f?
#13:04:26dbsmiker_: nope - check SL1 in the default EG install, same problem
#13:04:45miker_k
#13:05:01dbs(course, now I've gotta go check)
#13:06:24dbsmiker_: yep, just checked; University (3rd level) and University Library (4th level) both have can_have_vols=t
#13:06:45miker_k
#13:08:50dbsphasefx, miker_: thanks for the karma. sorry for the roughshod approach.
#13:09:14miker_nono ... all's well. as you said, that's what trunk is for
#13:10:35dbshttp://tvt.blogspot.com/2009/03/evergreen-patch-accepted.html
#13:11:59miker_nice :)
#13:17:31miker_translating SQL to json for fun and profit: http://rafb.net/p/XN1klc94.html ;)
#13:17:37miker_ waits for screams
#13:18:20dbswell, I guess it's really what a feature branch is for :)
#13:19:01dbsmiker_: heh. it's like sql, except harder to read (for me) :)
#13:19:32phase_bb2 has joined #openils-evergreen
#13:21:02dbs"give me the distinct set of circ event triggers for this user where state is pending or in error"?
#13:22:26miker_dbs: ineed
#13:22:32miker_on bot counts
#13:22:35miker_noth
#13:22:37miker_both
#13:22:43miker_ takes a typing class
#13:22:45dbs@count
#13:22:45pinesoldbs: Error: "count" is not a valid command.
#13:26:08phase_bb has quit IRC
#13:38:16miker_dbs: gonna talk my way through 43 ... ignore as appropriate ;)
#13:38:23dbsabsolutely
#13:38:37dbsI just can't figure out why the expected recursion doesn't occur
#13:39:37miker_so, we're in showLocal mode .. and not at the top of the tree, and ... do we have a node? hrm... no, because we're at the system level (first call)
#13:40:47miker_wait ... not at system, at library
#13:40:53miker_but still no node
#13:41:38miker_so, we loop over the first level kids in the tree, looking for the depth=1 anscestor of the current location
#13:42:04miker_we find the anscestor Local Library System
#13:43:46miker_we discover after building the result row that this does not have can_have_vols, so we remove the data sections and append the row
#13:44:19miker_then we loop over the children of that, and we /do/ pass the org (node) to the recursive call
#13:45:02miker_now we're at the University System level, with a node, and still in showLocal
#13:45:25miker_well ... there we go
#13:45:55miker_we have a node, and we're inside the first if() block. so we test thusly:
#13:45:59miker_if( !orgIsMine(loc, node) ) return;
#13:46:24miker_which says "if node is not a descendent of loc, bail"
#13:46:58miker_which is exactly correct, per the test, because node is a University System node, and loc is a University Library node
#13:47:19dbsmakes sense
#13:47:33dbswhen you keep all the vars straight like that
#13:47:34miker_it works with 3 levels, because orgIsMine(x,x) returns true (same org is a "my org")
#13:48:31miker_so, I think we just need to swap loc and node in if( !orgIsMine(loc, node) ) return; ... mind testing with: if( !orgIsMine(node,loc) ) return; ?
#13:48:46dbswill give it a shot, one sec
#13:49:06dbsat some point I have to prepare for tomorrow morning's deadly early flight
#13:49:17miker_:)
#13:53:47miker_how deadly early?
#13:53:58miker_"deadly enough, jackass"
#13:54:48dbs tries to force firefox to grab the updated copy of rdetail.js from the server; fails
#13:54:56miker_gah
#13:55:04miker_dbs: url?
#13:55:14dbss'ok, just restarting firefox
#13:55:45dbsi suspect firebug plays a part in defeating Shift-Reload
#13:56:13miker_ahh... yeah, I turn that off when I don't actively NEEEEED it.
#13:58:19dbsbahhhh! http://dwarf.cs.uoguelph.ca/opac/en-US/skin/default/js/rdetail.js
#13:58:32dbsI have changed the file on the server, restarted apache, ARGH
#14:00:08dbs restarts apache again, as opera picks up the same file
#14:00:49dbsugh, dbs unsafe at any speed - wrong skin
#14:01:39dbsthat fixed it, indeed
#14:02:24dbsworks in opera, too
#14:02:25miker_yay! ... I'll commit, then, and close the ticket ... it works at the university system level, yes?
#14:02:28dbsmiker_++
#14:03:13dbsaye
#14:04:17dbsbetween fixing that bug, and adding google integration, our folks will be heartened. now we just need to bang out an acquisition system ;)
#14:04:45dbsoh, and the answer to your question: 4:30 am pickup for a 6:15 am flight
#14:10:33natschil has joined #openils-evergreen
#14:11:58dbsmiker_: argh... would it be possible for that to not work in Internet Explorer?
#14:12:16dbs goes to check to see what version of rdetails.js IE is pulling down
#14:13:10miker_dbs: I can't see how the param order would matter :(
#14:13:16miker_hrm...
#14:13:30miker_let's commit this, then look at IE
#14:14:18dbsYeah. Might be lingering interference with the still-failing openils.I18N
#14:14:27dbshttp://dwarf.cs.uoguelph.ca/opac/en-US/skin/default/xml/rdetail.xml?l=103&d=3&t=mining&tp=keyword&hc=9980&r=126095&rt=keyword
#14:15:00dbsbet that's what the problem is
#14:17:03dbshmm, works in trunk. okay, never mind. got some backporting to do, methinks
#14:17:26miker_k
#14:17:36miker_I'll backport this to 1.4 and 1.4.0
#14:17:48miker_this being the param swap
#14:18:06dbs(openils.I18N is still failing, but we've switched the order in trunk so that it doesn't kill dijit.filteringSelect which throws an exception and brings everything to a crashing halt)
#14:18:17dbsright-o - fabulous
#14:18:31dbsand close :)
#14:24:27dbshmm, it might not work in IE in trunk :(
#14:25:41miker_I suspect 'for ( x in [] )' vs 'for (x; x < [].length; x++)' in IE ... want to try another patch in a sec?
#14:26:06dbsie--
#14:26:17dbssure
#14:27:12miker_http://rafb.net/p/h9k4ky14.html
#14:27:38miker_if that makes it happy I'll fix the dojo-fied version too
#14:30:26dbsi think that broke it
#14:30:55miker_huh
#14:31:55miker_in ffx?
#14:32:56miker_yeah ... me.children() is undefined
#14:34:13dbs gots to shower and pack and such
#14:34:23miker_is this in the default skin on dwarf?
#14:34:24dbsthanks a ton, miker_, we're making headway on ancient bugs
#14:34:30dbsyep
#14:34:33miker_ok ... have a good flight!
#14:34:36dbsI just pulled it back out
#14:34:39miker_k
#14:35:01dbsthanks!
#15:04:21natschil has quit IRC
#15:04:45natschil has joined #openils-evergreen
#15:09:51natschil has quit IRC
#15:09:56_natschil has joined #openils-evergreen
#15:14:08rsinger has quit IRC
#15:14:08berick has quit IRC
#15:14:08miker_ has quit IRC
#15:15:05rsinger has joined #openils-evergreen
#15:15:05berick has joined #openils-evergreen
#15:15:05miker_ has joined #openils-evergreen
#15:44:00lisppaste6 has quit IRC
#15:53:33djfiander has joined #OpenILS-Evergreen
#15:58:06_natschil has quit IRC
#16:25:19lisppaste6 has joined #openils-evergreen
#17:28:48djfiander has quit IRC
#21:39:19dbs has quit IRC
#21:41:04dbs has joined #openils-evergreen
#22:16:06dbs has quit IRC
< Saturday, March 7th, 2009Raw Log FileMonday, March 9th, 2009 >